Fix clamped capacity to be divided by element size #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 12, 2022
jkugelman
force-pushed
the
clamp-capacity-wording
branch
from
bb65ad6
to
fbe3482
Compare
- Fixes rust-bakery#1459 (comment) - Also change `clamp` to `min` so this works on Rust 2018 edition.
jkugelman
force-pushed
the
clamp-capacity-wording
branch
from
fbe3482
to
64216b8
Compare
Geal
reviewed
Dec 28, 2022
Geal
approved these changes
Dec 28, 2022
Pull Request Test Coverage Report for Build 3796644783Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1459 (comment): the capacity of a
Vec<O>is measured in number of elements not number of bytes, so divide 64KiB by the element size. This will round towards 0, which is desirable.